Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python_paths pytest option #2887

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Mar 20, 2023

What was wrong?

Tests on master are failing.

  • The python_paths option is deprecated.
  • eth-tester was failing because it couldn't find block 1

How was it fixed?

  • Removed the python_paths option.
  • Added a w3.testing.mine() to the failing eth-tester test. @fselmo: I didn't know if this was the right approach. I couldn't see anything immediately obvious about what might have changed with eth-tester to cause this failure.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes marked this pull request as ready for review March 20, 2023 21:00
@kclowes kclowes requested review from fselmo and pacrob March 20, 2023 21:12
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kclowes kclowes merged commit 6042f97 into ethereum:master Mar 20, 2023
@kclowes kclowes deleted the remove-python-paths branch March 20, 2023 21:30
@e3243eric e3243eric mentioned this pull request Mar 25, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants